[sheepdog] [PATCH] sheep: open files with O_EXCL when creating objects

Liu Yuan namei.unix at gmail.com
Fri Sep 14 06:43:42 CEST 2012


On 09/14/2012 12:26 PM, MORITA Kazutaka wrote:
> Using O_TRUNC with O_EXCL doesn't make sense and I think we don't need
> the flag at all.  This patch assumes that CREATE requests don't
> overwrite objects with different content.  Is it wrong?

I don't have questions for the patch objective. But I'm not sure if
there is previously existing object that has different content before we
executing the CREATE request. can O_TRUNC act as a safe guard?

Thanks,
Yuan



More information about the sheepdog mailing list