[sheepdog] [PATCH] Add command line option for binding to a specified interface.

Bryan D. Payne bdpayne at acm.org
Fri Sep 28 17:42:13 CEST 2012


> Nice work, but this patch has many style problems.  Can you run
> ./script/checkpatch.pl and fix the errors?

Here's the output that I see from that tool.  The one warning appears
to be a false positive as the other code defining command line
parameters is formatted exactly the same as my patch.  Are you seeing
different output.  What would you like for me to change in the patch
formatting?

Cheers,
-bryan


./script/checkpatch.pl
0001-Add-command-line-option-for-binding-to-a-specified-i.patch
WARNING: please, no spaces at the start of a line
#103: FILE: sheep/sheep.c:72:
+  -b, --bindaddr          specify IP address of interface to listen on\n\$

total: 0 errors, 1 warnings, 110 lines checked

0001-Add-command-line-option-for-binding-to-a-specified-i.patch has
style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.



More information about the sheepdog mailing list