[sheepdog] [PATCH 2/3] tests: add -j option for testing with journaling

Liu Yuan namei.unix at gmail.com
Thu Apr 11 06:58:43 CEST 2013


On 04/11/2013 12:48 PM, MORITA Kazutaka wrote:
> Hitoshi Mitake wrote:
>> > 
>> > At Wed, 10 Apr 2013 16:05:54 +0800,
>> > Liu Yuan wrote:
>>> > > 
>>> > > On 04/10/2013 03:51 PM, Hitoshi Mitake wrote:
>>>> > > > I don't disagree with making journaling as a default feature. But it
>>>> > > > seems that current journaling needs to be improved and debugged. I
>>>> > > > believe removing -j option should be done after enough stabilizing.
>>> > > 
>>> > > This process looks sens to me. I agree journaling need much debugging
>>> > > and improvement. So what do you think of 'improvement' to bring to
>>> > > journaling before we can apply it as default?
>> > 
>> > I believe -j option can be removed after passing all tests with -j
>> > option itself. Currently some tests fail with journaling. This
>> > wouldn't take a long time, -j is a temporal thing.
> We can turn -j into the option to disable journaling after making it
> the default.

Then it is better to keep this patch as local patch on your own to
assist debugging. After we pass all the tests, then -j can be used to
disable journaling as well as other options.

Thanks,
Yuan



More information about the sheepdog mailing list