[sheepdog] [PATCH] sheep: clean up SD_RES_xxx macros

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Fri Apr 12 09:01:47 CEST 2013


At Fri, 12 Apr 2013 14:22:49 +0800,
Liu Yuan wrote:
> 
> From: Liu Yuan <tailai.ly at taobao.com>
> 
> Currently it is a little bit mix that we put SD_RES_xxx for collie
> in sheepdog_proto.h but we put some SD_OP_xxx for collie in internal_proto.h.
> 
> Let's take a uniform view that take both inter-sheep and collie-sheep as
> internal protocols.
> 
> Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
> ---
>  include/internal_proto.h |   10 +++++++++-
>  include/sheepdog_proto.h |    8 --------
>  2 files changed, 9 insertions(+), 9 deletions(-)

Why don't you move SD_OP_xxx for collie to sheepdog_proto.h?  I'd like
to see the reason in the commit log.

Thanks,

Kazutaka



More information about the sheepdog mailing list