[sheepdog] [PATCH v4] sheepdog: add discard/trim support for sheepdog

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Apr 15 18:03:32 CEST 2013


At Mon, 15 Apr 2013 23:52:40 +0800,
Liu Yuan wrote:
> 
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 987018e..362244a 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -34,6 +34,7 @@
>  #define SD_OP_GET_VDI_INFO   0x14
>  #define SD_OP_READ_VDIS      0x15
>  #define SD_OP_FLUSH_VDI      0x16
> +#define SD_OP_DISCARD_OBJ    0x17

I think SD_OP_DISCARD_OBJ should be 0x05 since we are using a value
less than 0x10 for SD_OP_*_OBJ.

The other parts look good to me.

Thanks,

Kazutaka



More information about the sheepdog mailing list