[sheepdog] [PATCH RFC] employ gnu99 style of GCC

Liu Yuan namei.unix at gmail.com
Tue Apr 30 07:24:12 CEST 2013


On 04/29/2013 11:18 PM, Hitoshi Mitake wrote:
> Sorry, the second is incorrect. The notation like this cause errors
> even if -std=gnu99 is passed to gcc:
> 	struct journal_descriptor jd = {
> 		.magic = JOURNAL_DESC_MAGIC,
> 		.flag = JF_EPOCH,
> 		.epoch = epoch,
> 		.offset = 0,
> 		.size = size,
> 		.create = true,
> 	};
> 
> So we cannot count the second as a benefit.

So only variable declaration is the benefit and we have to give up
compound literals. I am not very convinced but if you insist, it is okay
to me.

Thanks,
Yuan



More information about the sheepdog mailing list