[sheepdog] [PATCH 02/14] tests: use $* instead of $@

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Apr 30 10:29:57 CEST 2013


The behavior of $@ in double quotations depends on the environment.
Actually, './check -valgrind' doesn't work on Fedora 16.  It is safe
to use $* instead of it.

Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
---
 tests/common.rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/common.rc b/tests/common.rc
index cfa94fa..c9ffe27 100644
--- a/tests/common.rc
+++ b/tests/common.rc
@@ -185,7 +185,7 @@ _valgrind_sheep()
             echo \"core dumped (${dir}/core)\"; kill \$PPID"
     opts="--db-attach=yes --db-command='${db_cmd}' --suppressions=valgrind.supp"
 
-    sh -c "echo y | valgrind ${opts} $SHEEP_PROG $@ -f -o 2>> ${dir}/sheep.log &"
+    sh -c "echo y | valgrind ${opts} $SHEEP_PROG $* -f -o 2>> ${dir}/sheep.log &"
 
     # wait for sheep to start up
     while true; do
@@ -198,7 +198,7 @@ _valgrind_sheep()
 _valgrind_collie()
 {
     logfile=$(mktemp)
-    valgrind --log-file=$logfile --error-exitcode=99 $COLLIE_PROG "$@"
+    valgrind --log-file=$logfile --error-exitcode=99 $COLLIE_PROG $*
     ret=$?
     if [ $ret == 99 ]; then
         cat $logfile 1>&2
-- 
1.8.1.3.566.gaa39828




More information about the sheepdog mailing list