[sheepdog] [PATCH 1/2] sheep: introduce strict mode for write

MORITA Kazutaka morita.kazutaka at gmail.com
Thu Dec 12 21:41:03 CET 2013


At Thu, 12 Dec 2013 14:37:23 +0800,
Liu Yuan wrote:
> 
> > > 
> > > Ah, yes. I think SD_FLAG_CMD_WRITE is kind of misleading (couple of times I
> > > forgot to assigne it while write something and spent time debugging it)
> > 
> > I think so too. hdr.data_length != 0 may have same meaning to the
> > flag. It can be removed.
> 
> But read has data_length != 0 too. I am wondering if SD_OP_{CREATE, WRITE}
> is good enough to indicate that this request has something to carry. Thus
> this flag can be removed.

We discussed the same thing before and I'm still against regarding
SD_OP_{CREATE, WRITE} as special ones.

I have a patch to add SD_FLAG_CMD_WRITE automatically, but it needs a
lot of work for rebasing.  I think I can take some time for it within
this year.  If you guys are fine with waiting another couples of
weeks, I'm happy to complete the work.

Thanks,

Kazutaka



More information about the sheepdog mailing list