[sheepdog] [PATCH] sheep: don't print error message when connection is off

Liu Yuan namei.unix at gmail.com
Wed Dec 18 04:23:27 CET 2013


On Tue, Dec 17, 2013 at 09:26:50PM +0800, Liu Yuan wrote:
> ...
> Dec 17 19:04:27  ERROR [net 11088] do_read(220) connection is closed (48 bytes left)
> Dec 17 19:04:27  ERROR [net 11088] rx_work(684) failed to read a header
> ...
> 
> This is quit annoying since nothing wrong with it and sheep.log is flooded with
> these messages.
> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  lib/net.c       |    2 +-
>  sheep/request.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/net.c b/lib/net.c
> index 9b0aa44..23c9e5d 100644
> --- a/lib/net.c
> +++ b/lib/net.c
> @@ -217,7 +217,7 @@ int do_read(int sockfd, void *buf, int len, bool (*need_retry)(uint32_t epoch),
>  reread:
>  	ret = read(sockfd, buf, len);
>  	if (ret == 0) {
> -		sd_err("connection is closed (%d bytes left)", len);
> +		sd_debug("connection is closed (%d bytes left)", len);
>  		return 1;
>  	}
>  	if (ret < 0) {
> diff --git a/sheep/request.c b/sheep/request.c
> index c542221..defffe8 100644
> --- a/sheep/request.c
> +++ b/sheep/request.c
> @@ -681,7 +681,7 @@ static void rx_work(struct work *work)
>  
>  	ret = do_read(conn->fd, &hdr, sizeof(hdr), NULL, 0, UINT32_MAX);
>  	if (ret) {
> -		sd_err("failed to read a header");
> +		sd_debug("failed to read a header");
>  		conn->dead = true;
>  		return;
>  	}

Applied

Yuan



More information about the sheepdog mailing list