[sheepdog] [PATCH v3 2/4] sheepdev: linux kernel module of block device driver for sheepdog

[levin li]

On 01/22/2013 01:20 PM, Liu Yuan wrote:
> On 01/22/2013 11:16 AM, levin li wrote:
>>   sheepdev/connect.c  | 178 ++++++++++
>>   sheepdev/device.c   | 985 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> As a general rule, if the proper code of one functions exceed 60 lines,
> try hard to rethink the structure of the function.
>
>>   sheepdev/proc.c     | 176 ++++++++++
>
> Check include/linux/string.c for string operations. I guess this will
> reduce much string operations code in proc.c Note kernel has deprecated
> strtok() as strseq().

I didn't use strtok or strseq, so I don't quite understand what's your 
meaning.

Thanks,

Levin

>
>>   sheepdev/sheep.c    | 186 ++++++++++
>>   sheepdev/sheepdev.h | 138 ++++++++
>
> Please slip this big patch for better review. I'd suggest proc.c and
> sheep.c as a separate preparation patch.
>
> Thanks,
> Yuan
>