[sheepdog] [PATCH] logger: clean printf styled log functions

MORITA Kazutaka morita.kazutaka at gmail.com
Wed Jan 23 15:25:12 CET 2013


At Wed, 23 Jan 2013 20:43:14 +0900,
Hitoshi Mitake wrote:
> 
> At Wed, 23 Jan 2013 17:25:37 +0800,
> Liu Yuan wrote:
> > 
> > On 01/23/2013 04:34 PM, Hitoshi Mitake wrote:
> > > Current sheep employes names "dprintf" and "vprintf" for its internal
> > > logging usage. Unfortunately glibc provides functions which have same
> > > names.
> > > 
> > > This patch clean these old functions and prepare new functions as
> > > alternatives. New functions are:
> > > 
> > > sd_printf(): A simple wrapper for log_write(). Caller has to pass log
> > > 	     level as its first parameter.
> > > sd_dprintf(): call log_write() with SDOG_DEBUG
> > > sd_eprintf(): call log_write() with SDOG_ERR
> > > sd_iprintf(): call log_write() with SDOG_INFO
> > 
> > I can't git am this patch, please rebase the patch to the latest master.
> 
> I checked but I couldn't find the problem. Is your latest master
> ef41ada575e50 (util: rename set_trimmed_sectors as
> untrim_zero_sectors)?

I've checked too, but it cannot be applied.  I ran the following
commands.

 $ git fetch github                # 'github' points git://github.com/collie/sheepdog.git
 $ git reset ef41ada575e50 --hard  # you created the patch against ef41ada575e50, right?
 $ git am -s your.patch            # this command fails

Thanks,

Kazutaka



More information about the sheepdog mailing list