[sheepdog] [PATCH 4/6] sheep, collie: use snprintf instead of sprintf to avoid buffer overflow

MORITA Kazutaka morita.kazutaka at gmail.com
Sun Jan 27 09:50:55 CET 2013


At Sun, 27 Jan 2013 15:43:45 +0800,
Liu Yuan wrote:
> diff --git a/include/logger.h b/include/logger.h
> index 0922401..ee97598 100644
> --- a/include/logger.h
> +++ b/include/logger.h
> @@ -19,6 +19,7 @@
>  
>  #define LOG_SPACE_SIZE (32 * 1024 * 1024)
>  #define MAX_MSG_SIZE 256
> +#define THREAD_NAME_LEN	20

Should be MAX_THREAD_NAME_LEN or similar.

The other parts of this series look good to me.

Thanks,

Kazutaka



More information about the sheepdog mailing list