[sheepdog] [PATCH v3 1/3] logger: format in logger process

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Wed Jan 30 02:41:00 CET 2013


At Tue, 29 Jan 2013 20:34:48 +0800,
Liu Yuan wrote:
> 
> On 01/29/2013 08:04 PM, Hitoshi Mitake wrote:
> > +static notrace int default_log_format(char *buff, size_t size,
> > +				const struct logmsg *msg)
> 
> This isn't properly aligned. Could you please also add a check to our
> checkpatch to detect such formatting errors?

What do you think proper indentation is?  Seems that emacs indents the
code as Hitoshi wrote if we use an example of .emacs in
http://www.kernel.org/doc/Documentation/CodingStyle

Thanks,

Kazutaka




More information about the sheepdog mailing list