[sheepdog] [PATCH 1/4] zookeeper: remove unneccessary zk operation

Liu Yuan namei.unix at gmail.com
Sat Jul 6 04:48:53 CEST 2013


On Sat, Jul 06, 2013 at 10:25:39AM +0800, Kai Zhang wrote:
> 
> On Jul 6, 2013, at 10:17 AM, Liu Yuan <namei.unix at gmail.com> wrote:
> 
> > Only there is only one sheep (who sends BLOCK) will have block->callbacked set
> > true. We have to update all the state of sheep from blocked to unblock, we need
> > to broadcast notify.
> 
> I think we can update all the state of sheep from blocked to unblock by broadcasting
> 'UNBLOCK'. But currently, we broadcast 'UNBLOCK' and 'NOTIFY'.
> I think we can merge them.
> 
> One 'UNBLOCK' can act as the same as before except reduce on broadcast action.

Maybe yes, but I'd like to see the patch to proof the idea.

Thanks
Yuan



More information about the sheepdog mailing list