[sheepdog] [PATCH v3] sheep: remove master node

[Kai Zhang]

On Jul 24, 2013, at 3:00 PM, MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp> wrote:

> At Tue, 23 Jul 2013 17:23:44 +0800,
> Kai Zhang wrote:
>> 
>> On Jul 23, 2013, at 4:44 PM, MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp> wrote:
>> 
>>> Should I include my zookeer patch into this series?  You know, my
>>> zookeeper patch didn't remove the zk master in either way.  But if you
>>> want to do your work onto my patch, I'll include my zk patch again
>>> into the v4 series.
>> 
>> If the patch is an separate one and has been done, I would like to see it in v4 : )
> 
> Well, the patch was in my v1 series.
> 
>  http://lists.wpkg.org/pipermail/sheepdog/2013-July/010804.html
> 
> You will try to completely remove a master from the zk driver, right?
> If the change looks okay to you, I'll add it to v4.  If not sure, I
> think it's better to keep it out of this series.
> 

I just took a look at v1, and I think there is some problem.

The fatal error is caused by zk_member_empty().
We cannot determine if the cluster is empty by zk_member_empty().

For example, when two sheep join at the same time, zk_member_empty() will return true
for both of the sheep.
And this is not what we expect.

Thanks,
Kyle