[sheepdog] [PATCH] checkpath: fix block comment false alarm

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Wed Jul 24 11:33:11 CEST 2013


At Wed, 24 Jul 2013 17:27:06 +0800,
Liu Yuan wrote:
> 
> >
> > At Wed, 24 Jul 2013 12:53:55 +0800,
> > Liu Yuan wrote:
> > >
> > > +* blabla.
> > > +* blabla.
> > > +*/
> > >
> > > Above in the patch file is valid block comments
> > >
> > > Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> > > ---
> > >  script/checkpatch.pl |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/script/checkpatch.pl b/script/checkpatch.pl
> > > index ccdc58a..42f5d7d 100755
> > > --- a/script/checkpatch.pl
> > > +++ b/script/checkpatch.pl
> > > @@ -1736,7 +1736,7 @@ sub process {
> > >                               # case E
> > >                               my $ln = $linenr;
> > >                               while ($rawlines[$ln] !~ /^\+\s*\/\*/ &&
> $ln >= 0) { $ln--; }
> > > -                             if ($rawlines[$ln] !~ /^\+\s*\/\*$/) {
> > > +                             if ($rawlines[$ln] =~ /^\+\s*\/\*/ && !~
> /^\+\s*\/\*$/) {
> >
> > What is this trying to check?  This cauese a parse error on my
> > environment (perl v5.10.1).
> 
> see commit log, it will report falsely for the metioned example. the patch
> is wrong I will send v2

Yes, I know the intention.  What I didn't understand was what the code
was exactly doing.

Thanks,

Kazutaka



More information about the sheepdog mailing list