[sheepdog] [PATCH v2] zookeeper: exit program on unrecoverable error

MORITA Kazutaka morita.kazutaka at gmail.com
Mon Jun 17 05:42:51 CEST 2013


At Mon, 17 Jun 2013 10:26:28 +0800,
Kai Zhang wrote:
> 
> On Jun 17, 2013, at 8:07 AM, MORITA Kazutaka <morita.kazutaka at gmail.com> wrote:
> 
> > On the second thought, this patch doesn't seem to break epoch
> > directly.  However, without this patch, zk_queue_peek() can return
> > false wrongly when the session timeout happens and sheep can start a
> > block operation while another block operation is ongoing.  This might
> > be the reason I saw a epoch corruption, but I'm not sure now.
> > 
> 
> I think another block operation cannot be started because the session has timeout and any zookeeper operation will fail.

If zk_queue_peek() returns false, zk_event_handler() can call
kick_block_event() and sd_block_handler() can be called before any
other zk operations?

Thanks,

Kazutaka



More information about the sheepdog mailing list