[sheepdog] [PATCH] gitignore: ignore produced man files

MORITA Kazutaka morita.kazutaka at gmail.com
Tue Jun 25 02:03:46 CEST 2013


At Tue, 25 Jun 2013 00:27:42 +0800,
Liu Yuan wrote:
> 
> On Tue, Jun 25, 2013 at 01:07:39AM +0900, MORITA Kazutaka wrote:
> > At Mon, 24 Jun 2013 23:59:50 +0800,
> > Liu Yuan wrote:
> > > 
> > > On Tue, Jun 25, 2013 at 12:56:58AM +0900, Hitoshi Mitake wrote:
> > > > At Mon, 24 Jun 2013 20:22:58 +0800,
> > > > Liu Yuan wrote:
> > > > > 
> > > > > On 06/24/2013 09:52 AM, Hitoshi Mitake wrote:
> > > > > > Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> > > > > > ---
> > > > > >   .gitignore |    2 ++
> > > > > >   1 files changed, 2 insertions(+), 0 deletions(-)
> > > > > >
> > > > > > diff --git a/.gitignore b/.gitignore
> > > > > > index f333fd3..e7a577c 100644
> > > > > > --- a/.gitignore
> > > > > > +++ b/.gitignore
> > > > > > @@ -69,3 +69,5 @@ tests/atconfig
> > > > > >   tests/*.out.bad
> > > > > >
> > > > > >   *.patch
> > > > > > +
> > > > > > +man/*.8
> > > > > >
> > > > > 
> > > > > Do you have any problem with it? (I don't with guilt) If we ignore 
> > > > > man/*.8, how can we patch these files later?
> > > > 
> > > > The *.8 files are generated things during build time like *.o. They
> > > > should be ignored by git.
> > > 
> > > Not true for all the content of *.8, only partially auto-generated. Anyway 
> > > does this cause problem for you?
> > 
> > 'git show' shows *.8 as untracked files if we don't include them into
> > .gitignore.  At least, sheep.8, collie.8, and sheepfs.8 should be
> > ignored.
> 
> If we put it these into ingore list, what about we patch these files later? Can
> git format-patch work without problem?

What kind of patch are you talking about?  Currently, all the man/*.8
files are auto-generated from man/*.8.in and we don't create a patch
against *.8.

In future, we may add another man file which is controlled by git (not
auto-generated).  In that sense, I think adding 3 files (sheep.8,
collie.8, and sheepfs.8) explicitly to .gitignore is better.

Thanks,

Kazutaka



More information about the sheepdog mailing list