[sheepdog] [PATCH] sockfd_cache: close socket always when node is crashed

Liu Yuan namei.unix at gmail.com
Thu May 2 05:29:31 CEST 2013


On 05/02/2013 10:48 AM, MORITA Kazutaka wrote:
> Another approach is removing sockfd_cache_put() from
> sheep_del_sockfd(), and setting false to fd.in_use in
> sockfd_cache_del().  I didn't take this approach because it needs more
> modifications and would break the current stable code.

It looks that we only need fold sockfd_cache_put into sockfd_cache_del
with the same lock context in the sheep_del_sockfd(), not a big
modification, no?

Thanks,
Yuan



More information about the sheepdog mailing list