[sheepdog] [PATCH v5 08/16] collie/farm: implement object_tree

Liu Yuan namei.unix at gmail.com
Mon May 20 13:37:55 CEST 2013


On 05/20/2013 03:50 PM, Kai Zhang wrote:
> +struct obj_rb_entry {
> +	uint64_t oid;
> +	int nr_copies;
> +	struct rb_node node;
> +	struct list_head list;
> +};
> +
> +struct obj_rb_tree {
> +	int nr_objs;
> +	struct rb_root root;
> +	struct list_head list;
> +};

I'd suggest change obj_rb to object_*. Code 'rb' in the name doesn't
help people understand the code. And struct object_tree_entry, struct
object_tree will make the code more uniform.

Thanks,
Yuan



More information about the sheepdog mailing list