[sheepdog] [PATCH v2 02/11] tests: use mkfs.ext3 only for _make_device

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Mon May 27 09:48:02 CEST 2013


At Mon, 27 May 2013 14:22:54 +0800,
Liu Yuan wrote:
> 
> This is a preparation patch for 'remove -s option'. After '-s' is removed,
> since every file system has its own metadata allocation mechanism, so we can't
> use different file system to get the same size after formatting.

The subject should be changed from ext3 to ext4.

> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  tests/common.rc |   20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/tests/common.rc b/tests/common.rc
> index 82314a2..1971ac6 100644
> --- a/tests/common.rc
> +++ b/tests/common.rc
> @@ -366,24 +366,8 @@ _make_device()
>          _die "failed to create $STORE/$idx.img"
>      fi
>  
> -    fstype="$(df -T / | tail -1 | awk '{print $2}')"
> -    case $fstype in
> -        ext2)
> -            mkops="-t $fstype -q -F"
> -            mntops="-o user_xattr"
> -            ;;
> -        ext[3-4])
> -            mkops="-t $fstype -q -F -J size=4"
> -            mntops="-o user_xattr"
> -            ;;
> -        xfs)
> -            mkops="-t $fstype -f"
> -            mntops=""
> -            ;;
> -        *)
> -            _die  "For now we only support xfs and ext*."
> -            ;;
> -    esac
> +    mkops="-t ext4 -q -F -J size=4"

'-j size=4' is a trick to get the same output with ext3.  I'd suggest
disabling journal completely with '-O ^has_journal'.

Thanks,

Kazutaka



More information about the sheepdog mailing list