[sheepdog] [PATCH 3/4] work: let worker threads start with pipe()

Liu Yuan namei.unix at gmail.com
Tue Oct 22 09:43:52 CEST 2013


On Tue, Oct 22, 2013 at 04:13:12PM +0900, Hitoshi Mitake wrote:
> Current work.c uses mutex for starting worker threads
> (startup_lock). The intention of the code is hard to understand. In
> addition, the code doesn't destroy newly created threads when it fails
> creating or growing work queues.
> 
> This patch refactors the code and implement correct cleaning of
> threads.
> 
> Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> ---
>  lib/work.c |   59 +++++++++++++++++++++++++++++++++++++++++++----------------

I don't see the point that you make the code simpler with pipe, you add more
lines than removal!

Thanks
Yuan



More information about the sheepdog mailing list