[sheepdog] [PATCH] Fix some problems of Debian package

[YunQiang Su]

On Tue, Sep 24, 2013 at 2:43 PM, MORITA Kazutaka
<morita.kazutaka at gmail.com> wrote:
> Hi YunQiang,
>
> Thanks for your contribution.
>
> Can you split this patch into smaller ones for easier to review?
>
> I'd suggest at least 7 patches.
>  - add translation files
>  - update URLs
>  - fix the destination directory
>  - modify the priority of sheepdog/start?
>  - remove deprecated (and useless?) import
>  - avoid creating symbolic link
>  - remove a data directory when purge option is specified
Thanks for you suggestion. I will do so right now.
>
>> > --- a/debian/sheepdog.config
>> > +++ b/debian/sheepdog.config
>> > @@ -12,6 +12,7 @@ if [ -r /etc/default/sheepdog ] ; then
>> >         fi
>> >         db_set sheepdog/daemon_args "$DAEMON_ARGS"
>> >  fi
>> > +db_input low sheepdog/start || true
>> >  db_input medium sheepdog/start || true
>
> I'm not sure what is intended with this change.  Perhaps, you forgot
> to remove the "db_input medium sheepdog/start" line?
Ohhh, it's a mistake when merge patches.
>
>> >  db_input medium sheepdog/daemon_args || true
>> >  db_go || true
>> > diff --git a/debian/sheepdog.init b/debian/sheepdog.init
>> > index 648ce30..9b03564 100644
>> > --- a/debian/sheepdog.init
>> > +++ b/debian/sheepdog.init
>> > @@ -36,9 +36,6 @@ if [ "$START" != "yes" ]; then
>> >         exit 0
>> >  fi
>> >
>> > -# Load the VERBOSE setting and other rcS variables
>> > -. /lib/init/vars.sh
>> > -
>> It is deprecated now.
>
> Can you explain what the script did and why we can safely remove it
> now?
I was included by an old dh_make automatic, although that it is not
needed any way.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710559
>
>> >  # Define LSB log_* functions.
>> >  # Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
>> >  . /lib/lsb/init-functions
>> > diff --git a/debian/sheepdog.links b/debian/sheepdog.links
>> > new file mode 100644
>> > index 0000000..40940d1
>> > --- /dev/null
>> > +++ b/debian/sheepdog.links
>> > @@ -0,0 +1 @@
>> > +/usr/sbin/dog /usr/sbin/collie
>> > diff --git a/debian/sheepdog.postinst b/debian/sheepdog.postinst
>> > index c0d3c0f..bc72f06 100644
>> > --- a/debian/sheepdog.postinst
>> > +++ b/debian/sheepdog.postinst
>> > @@ -24,8 +24,6 @@ if [ "$1" = "configure" ] ; then
>> >         db_stop || true
>> >  fi
>> >
>> > -ln -s -f /usr/sbin/dog /usr/sbin/collie
>> > -
>> Don't do it like, or it will escape from dpkg's track
>
> We need /usr/sbin/collie for the backward compatibility.  Is there any
> way to install /usr/sbin/collie?
debian/sheepdog.links does it.
>
> Thanks,
>
> Kazutaka



-- 
YunQiang Su