[sheepdog] [PATCH v4] dog/vdi: bug fix for voting majority, add test case to test it
namei.unix at gmail.com
Thu Apr 10 06:58:39 CEST 2014
On Thu, Apr 10, 2014 at 01:09:48PM +0900, Hitoshi Mitake wrote:
> On Tue, Apr 8, 2014 at 6:52 PM, Ruoyu <liangry at ucweb.com> wrote:
> > There is a critical error in the function vote_majority_object.
> > When all the three copies are different, the original logic still
> > choose the last one as majority.
> > The root cause is step 2 of the voting algorithm was missed.
> > Signed-off-by: Ruoyu <liangry at ucweb.com>
> > ---
> > dog/vdi.c | 22 +++++++++++++---
> > tests/functional/077 | 65 ++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/functional/077.out | 45 +++++++++++++++++++++++++++++++++
> > 3 files changed, 129 insertions(+), 3 deletions(-)
> Looks good to me, thanks for your fix.
> Reviewed-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
More information about the sheepdog