[sheepdog] [PATCH] tests/unit: unit test failed because interfaces were changed.

Ruoyu liangry at ucweb.com
Tue Apr 15 09:45:30 CEST 2014


On 2014年04月15日 14:46, Liu Yuan wrote:
> On Tue, Apr 15, 2014 at 11:37:27AM +0800, Ruoyu wrote:
>> This patch only let 'make check' workable, does not add any cases.
>>
>> Signed-off-by: Ruoyu <liangry at ucweb.com>
>> ---
>>   tests/unit/sheep/test_hash.c | 94 +++++++++++++++++++++++++++++++++++++++++++-
> Why we need to hard-wire some codes from md.c instead of simply #include "md." as
> before?
I think it is better to expose these interfaces: create_vdisks, 
remove_vdisks and vdisk_cmp. The patch is ugly, but at least it is runnable.
>
> Thanks
> Yuan





More information about the sheepdog mailing list