[sheepdog] [PATCH v3 0/9] object reclaim based on generational reference counting

Liu Yuan namei.unix at gmail.com
Thu Feb 27 06:59:13 CET 2014


On Thu, Feb 27, 2014 at 11:57:13AM +0900, Hitoshi Mitake wrote:
> At Mon, 24 Feb 2014 18:16:17 +0800,
> Liu Yuan wrote:
> > 
> > On Mon, Feb 24, 2014 at 05:52:28PM +0900, MORITA Kazutaka wrote:
> > > At Mon, 24 Feb 2014 11:08:28 +0800,
> > > Liu Yuan wrote:
> > > > 
> > > > On Sun, Feb 23, 2014 at 07:08:27PM +0900, Hitoshi Mitake wrote:
> > > > > On Sun, Feb 23, 2014 at 2:28 PM, Hitoshi Mitake
> > > > > <mitake.hitoshi at gmail.com> wrote:
> > > > > > The object reclaim doesn't support hypervolume yet. But hypervolume cannot be
> > > > > > used as a virtual disk (both of qemu and tgt don't support it) currently. And
> > > > > > the removal of old vdi deletion is acceptable for hypervolume because it doesn't
> > > > > > support snapshot, etc. So I think this patchset can be applied to the master
> > > > > > branch.
> > > > > >
> > > > 
> > > > I don't think we should merge this patch set in such a haste because it is in
> > > > the critical deletion patch that is unlike conditional feature, e.g, nfs, http
> > > > that if not enabled, users won't be affected. There are some uers like us using
> > > > master branch as the production base. I think of marking the master tip as 
> > > > stable-0.8.1 before applying this patch set.
> > > 
> > > What do you mean?  I think 0.8.1 should be marked in the stable-0.8
> > > branch.  I really don't think using a master branch for production is
> > > a good idea.
> > 
> > We want use some features like multi-threaded recovery which is not in the
> > stable-0.8 and other works in http. These works might not be suitable to
> > backport to stable-0.8. So we have to use code base on master tip (or some 
> > commit).
> 
> The multithreaded recovery can be backported to stable-0.8 (and also
> stable-0.7), because it doesn't cause incompatibility. But I need time
> for checking it is enough mature.
> 
> Does "other works in http" mean the new interface of sheepfs for http?
> It can also be backported to stable-0.8. Basically I backport patches
> for improving stability of sheepdog, but backporting new features which
> don't cause incompatibility is no problem.

Okay, I think it is good to merge it at master after passing Valerio's test
and adding more tests.

Thanks
Yuan



More information about the sheepdog mailing list