[sheepdog] [PATCH 1/2] sheep: exit when a passed path of log dir is not a directory

Liu Yuan namei.unix at gmail.com
Fri Jan 17 10:04:02 CET 2014


On Fri, Jan 17, 2014 at 08:35:58AM +0900, Hitoshi Mitake wrote:
> This patch lets sheep exit as soon as possible when the option of log
> directory (specified with "-l dir=") is not a directory, but an
> ordinal file. When a path of ordinal file is passed, logger process
> runs as a defunct process. This behavior is confusing for
> administrators.
> 
> The purpose of this change is preventing operation miss. If sheep is
> passed a wrong path name of log directory, it should notify the
> mistake to administrator. Running without correct logging is really
> wrose in production environment.
> 
> In addition, this patch does a trivial cleaning. The variable path in
> main() of sheep is too generic. So this patch renames it to log_path.
> 

Applied this one, thanks

Yuan



More information about the sheepdog mailing list