[sheepdog] [PATCH v2] tests/func: fix Copies output due to format change

MORITA Kazutaka morita.kazutaka at gmail.com
Thu Jan 23 07:23:39 CET 2014


At Thu, 23 Jan 2014 14:08:23 +0800,
Liu Yuan wrote:
> 
> On Thu, Jan 23, 2014 at 02:45:48PM +0900, MORITA Kazutaka wrote:
> > At Wed, 22 Jan 2014 14:04:35 +0800,
> > Liu Yuan wrote:
> > > 
> > > diff --git a/tests/functional/common.rc b/tests/functional/common.rc
> > > index 3785bae..b304580 100644
> > > --- a/tests/functional/common.rc
> > > +++ b/tests/functional/common.rc
> > > @@ -486,7 +486,7 @@ _cluster_format()
> > >  
> > >  _random()
> > >  {
> > > -	openssl enc -rc4 -pass pass:"$(date)" -nosalt < /dev/zero 2>/dev/null
> > > +	openssl enc -bf-cbc -pass pass:"$(date)" -nosalt < /dev/zero 2>/dev/null
> > >  }
> > 
> > What's the intention of this change?
> > 
> 
> for now -rc4 cause a segfault on ubuntu-13.04 latest. Previously, -bf-cbc cause
> a segfault of openssl, but now bf-cbc works fine.

It's not good to change the encode type for each we encounter a
segfault.  I think removing -nosalt would work for any kind of encode
types.

Anyway, this change should be in another patch.

Thanks,

Kazutaka



More information about the sheepdog mailing list