[sheepdog] [PATCH] dog: remove alter subcommand and migrate sub-sub commands

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Wed Jul 23 06:23:51 CEST 2014


At Tue, 22 Jul 2014 16:49:05 +0900,
Hitoshi Mitake wrote:
> 
> At Tue, 22 Jul 2014 16:32:06 +0900,
> Hitoshi Mitake wrote:
> > 
> > The name of subcommand "dog alter" is strange and confusing. Because
> > many other commands of dog alter state of sheep cluster. This patch
> > removes the subcommand and move sub-sub commands as below:
> > - dog alter vdi-copy -> dog vdi alter-copy
> > - dog alter cluster-copy -> dog cluster alter-copy
> > 
> > Cc: Ruoyu <liangry at ucweb.com>
> > Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> > ---
> >  dog/Makefile.am |   3 +-
> >  dog/alter.c     | 253 --------------------------------------------------------
> >  dog/cluster.c   |  83 +++++++++++++++++++
> >  dog/dog.c       |   1 -
> >  dog/vdi.c       | 116 ++++++++++++++++++++++++++
> >  5 files changed, 200 insertions(+), 256 deletions(-)
> >  delete mode 100644 dog/alter.c
> 
> Ruoyu, could you review this patch? If it looks good to you, I'll push
> it to master.
> 

Applied with a fix for --copies option. If Yuan disagrees strongly,
I'll revert it.

Thanks,
Hitoshi



More information about the sheepdog mailing list