[sheepdog] [PATCH v2 2/4] dog: use nr_copies of inode object instead of command line parameter

Hitoshi Mitake mitake.hitoshi at gmail.com
Wed May 7 16:38:28 CEST 2014

From: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

Current "dog vdi clone" has a possibility of creating clone volume
which has a different replica number from its original volume when it
receives -c option. This patch forbid such a situation by letting
vdi_clone() use inode->nr_copies instead of vdi_cmd_data.nr_copies
(the variable which holds a value passed with -c option).

Cc: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
Cc: Valerio Pachera <sirio81 at gmail.com>
Cc: Alessandro Bolgia <alessandro at extensys.it>
Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

v2: enhance commit log

 dog/vdi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dog/vdi.c b/dog/vdi.c
index 1851a2a..7cf1bf1 100644
--- a/dog/vdi.c
+++ b/dog/vdi.c
@@ -562,7 +562,7 @@ static int vdi_clone(int argc, char **argv)
 		goto out;
 	ret = do_vdi_create(dst_vdi, inode->vdi_size, base_vid, &new_vid, false,
-			    vdi_cmd_data.nr_copies, inode->copy_policy,
+			    inode->nr_copies, inode->copy_policy,
 	if (ret != EXIT_SUCCESS || !vdi_cmd_data.prealloc)
 		goto out;

More information about the sheepdog mailing list