[sheepdog] [PATCH v3] new feature of changing the replica number of existing cluster/vdi

Liu Yuan namei.unix at gmail.com
Mon May 26 15:52:49 CEST 2014

On Wed, May 21, 2014 at 03:14:41PM +0800, Ruoyu wrote:
> 1. To set the replica number of cluster:
>     dog alter cluster-copy -c <copies>
> 2. To set the replica number of standalone vdi who has neither
>    parent nor children:
>     dog alter vdi-copy -c <copies> <vdiname>
> 3. To set the replica number of shared vdi who has parent or children,
>    please run dog vdi clone command with -R (--root) option first:
>     dog vdi clone -s <snapshot> -R <src vdi> <dst vdi>
>    It will deep copy a brand new standalone vdi base on source vdi
>    so that we can run dog vdi copies to change destinate vdi's
>    replica number later.

Overall this patch looks good to me, some minor comments.

- --root is somewhat hard to perceive for ordinary uesrs. I'd suggest
  dog vdi clone {-N, --no-share} for the new clone that share nothing with its
  perent. Then it would be safe to change its copy level.

- some lines over 80.


More information about the sheepdog mailing list