[sheepdog] [PATCH 1/2] dog: fix cluster-wide snapshot inconsistency due to vdi deleted

[Liu Yuan]

On Mon, Sep 01, 2014 at 02:04:51PM +0800, Ruoyu wrote:
> Once vdi snapshot is deleted before executing 'dog cluster snapshot
> save', error messsage just like as below is seen.
> 
> Failed to read object 807c2b2500000000 No object found
> Failed to read inode header
> 
> Once a vdi is deleted, cluster snapshot save will not backup it to
> farm so that cluster snapshot load cannot restore it to new cluster.
> However, the vdi id is marked as in use for safety, vdi list
> will try to read all vdis in use. Therefore, dog cannot read the object.
> 
> The solution is saving the deleted vdi object too. To achieve it,
> a parameter, no_deleted, is added to the function parse_vdi.
> The default value is true. But for cluster snapshot save, it is false.
> 
> Reported-by: Valerio Pachera <sirio81 at gmail.com>
> Cc: Liu Yuan <namei.unix at gmail.com>
> Signed-off-by: Ruoyu <liangry at ucweb.com>
> ---
> v2:
>  - use no_deleted instead of include_deleted, advised by Yuan.
> 

Applied thanks

Yuan