[sheepdog] confused comments of vdi_snapshot

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Thu Apr 23 06:43:22 CEST 2015


At Wed, 22 Apr 2015 20:04:45 +0800,
Yu Yang wrote:
> 
> In sheep/vdi.c, the comments of function (line 1578)
> 	int vdi_snapshot(const struct vdi_iocb *iocb, uint32_t *new_vid)
> says :
>  * Both rollback and snap create started with current working VDI's snap_id + 1.
> Working VDI
>  * always has the highest snapid.
> 
> It seems that working VDI's snapid is always 0 , and has the highest vdi id (not
> snapid) . 
> Am I right?

You are right. It seems that the meaning of snapid was changed long ago.

I'm really glad if you can fix it :)

Thanks,
Hitoshi

> 
> Thanks.
> 
> 
> 
> 
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> https://lists.wpkg.org/mailman/listinfo/sheepdog



More information about the sheepdog mailing list