[sheepdog] [PATCH] sheep/request.c: fix bug of parameter passing in listen_handler

[Hitoshi Mitake]

At Mon, 18 May 2015 14:38:52 +0800,
Meng Lingkun wrote:
> 
> It's confused to pass bool to struct cluster_info. Because it's
> not used in create_client, passing NULL is better.
> 
> Signed-off-by: Meng Lingkun <menglingkun at cmss.chinamobile.com>
> ---
>  sheep/request.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sheep/request.c b/sheep/request.c
> index f12ca6b..cec13a2 100644
> --- a/sheep/request.c
> +++ b/sheep/request.c
> @@ -1070,7 +1070,7 @@ static void listen_handler(int listen_fd, int events, void *data)
>  		}
>  	}
>  
> -	ci = create_client(fd, data);
> +	ci = create_client(fd, NULL);

The policy of this change seems reasonable. But the parameter of
create_client() seems to be outdated. Could you eliminate it from both
of caller and callee?

Thanks,
Hitoshi

>  	if (!ci) {
>  		close(fd);
>  		return;
> -- 
> 1.7.1
> 
> 
> 
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> https://lists.wpkg.org/mailman/listinfo/sheepdog