[sheepdog] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc()

Kevin Wolf kwolf at redhat.com
Tue May 22 13:12:05 CEST 2018

Am 18.05.2018 um 20:17 hat Peter Maydell geschrieben:
> In commit 8b9ad56e9cbfd852a, we removed the code that could result
> in our getting to sd_prealloc()'s out_with_err_set label with a
> NULL blk pointer. That makes the NULL check in the error-handling
> path unnecessary, and Coverity gripes about it (CID 1390636).
> Delete the redundant check.
> Signed-off-by: Peter Maydell <peter.maydell at linaro.org>

In fact, it was unnecessary even before that, because blk_unref(NULL)
is valid (it does nothing).

Thanks, applied to the block branch.


More information about the sheepdog mailing list