[sheepdog] [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

Eric Blake eblake at redhat.com
Thu Mar 26 14:27:56 CET 2020

On 3/26/20 8:22 AM, Maxim Levitsky wrote:
> On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote:
>> On 3/25/20 8:12 PM, Maxim Levitsky wrote:
>>> This will allow to reuse a single generic .bdrv_co_create
>> "allow to ${verb}" is not idiomatic, better is "allow ${subject} to
>> ${verb}" or "allow ${verb}ing".  In this case, I'd go with:
>> This will allow the reuse of a single...
> I agree! This commit will probably go as is but next time I'll keep it in mind!

Max hasn't sent the pull request yet; there's still time for him to 
amend his staging queue if he wants.  But yeah, it's not a huge deal if 
the patch goes in without spelling/grammar polish.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

More information about the sheepdog mailing list