[Stgt-devel] FirstBurstLenght > MaxBurstLength --> error

[Mike Christie]

FUJITA Tomonori wrote:
> From: Albert Pauw <albert.pauw at gmail.com>
> Subject: [Stgt-devel] FirstBurstLenght > MaxBurstLength --> error
> Date: Sun, 15 Apr 2007 11:33:27 +0200
> 
>> Running the test regression script of open-iscsi on stgt I found an 
>> error, which I did not encounter with other targets.
>>
>> It is test #17 with the following parameters:
>>
>> ================== TEST #17 BEGIN ====================
>> ImmediateData = No
>> InitialR2T = No
>> HeaderDigest = None
>> DataDigest = None
>> FirstBurstLength = 8192
>> MaxBurstLength = 4096
>> MaxRecvDataSegmentLength = 4096
>> MaxOutstandingR2T = 1
>>
>> I get the error "Invalid burst lengths first_burst 8192 max_burst 4096" 
>> in /var/log/messages and the login breaks of.
>> According to the RFC 3720 "FirstBurstLength MUST NOT exceed 
>> MaxBurstLength" (chap 12.14), which means that the target
>> should answer back with a FirstBurstLenght parameters equal to 
>> MaxBurstLenght.
>>
>> I investigated with wireshark and found that this is exactly the 
>> behaviour of the Wasabi Storagebuilder target,
>> iscsi-target silently accepts FirstBurstLength > MaxBurstLength, and 
>> stgt only gives an error.
> 
> Thanks a lot.
> 
> I put it on my to do list since it's a bit tricky to handle this.
> 
> BTW, would it better for open-iscsi not to send invalid parameters?

I will fix that on my side.