[Stgt-devel] [PATCH] iscsi no spin with async bs

FUJITA Tomonori tomof
Thu Aug 2 07:25:29 CEST 2007


On Mon, 30 Jul 2007 13:31:44 -0400
Pete Wyckoff <pw at osc.edu> wrote:

> A missing call to tgt_event_modify(fd, EPOLLIN) is added.  Without this, an
> asynchronous backing store would cause tgtd to spin in epoll, always
> reporting EPOLLOUT on the socket but having nothing to write.  When the
> thread completes the command, the bs will cause cmd_done, turning EPOLLOUT
> back on.
> 
> No change for synchronous backing stores, as epoll does not get called
> until the command completes.
> 
> It would also spin briefly waiting for the rest of the unsolicited packets,
> in both sync and async cases.
> 
> Signed-off-by: Pete Wyckoff <pw at osc.edu>
> ---
>  usr/iscsi/iscsid.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

BTW, I think that all the backing store code works asynchronously.



More information about the stgt mailing list