[Stgt-devel] [PATCH 4/4] OSD command parser

[FUJITA Tomonori]

From: Pete Wyckoff <pw at osc.edu>
Subject: Re: [Stgt-devel] [PATCH 4/4] OSD command parser
Date: Wed, 21 Feb 2007 13:30:58 -0500

> fujita.tomonori at lab.ntt.co.jp wrote on Mon, 19 Feb 2007 23:32 +0900:
> > I put a patch to support various device types:
> > 
> > http://zaal.org/tgt/device-types.diff
> > 
> > I don't merge it because:
> > 
> > - only iscsi + AIO works (sg and ibmvio are broken).
> > 
> > - there are still lots of things to implement
> > 
> > - huge cleanup is necessary
> > 
> > I took an approach discussed a long time ago in IET mailing list. Each
> > device type has its own function array (like sbc_mode_sense). spc code
> > exports some common functions. A LLD can cleanly replace functions in
> > arrays (so we can kill dirty hack in tgt_driver struct). A transport
> > class also needs that (though we don't implement yet).
> 
> That would be a reasonable approach, although the tables will be
> very sparse.  I shouldn't have too much trouble factoring out my
> current osd_cmd_perform into separate functions with shared
> routines.  If you check your patch in, I'll do this and try to help
> fix up the bugs and missing pieces.

More work is necessary before merging that patch. I'll try to finish
it this weekend.


> We'll still have to do something with bkio_submit_t to support
> bidirectional and to support returning both data and sense.  I have
> such a thing for OSD but have not tried to make all the other
> devices fit it pending your perusal.

If you send these patches, I'll try to fix and merge them.


> The other largish piece I'm carrying around is AHS support for
> iscsi.

ditto.


Thanks,