[Stgt-devel] [PATCH 4/4] OSD command parser

[Pete Wyckoff]

blackmagic02881 at gmail.com wrote on Mon, 22 Jan 2007 14:35 -0500:
> not a good idea. suggest to keep in a way like IET code, for each target
> type, call its foo_cmd_perform(), and make some common spc function as
> helper functions.

I think you're saying that I should duplicate the switch() logic for
the SPC commands in all the (osd|sbc|mmc|...)_cmd_perfom()
type-specific functions.  This would reduce scsi_cmd_perform() into
just a check on the target type, with no handling of SPC commands,
e.g. INQUIRY.

I'm not opposed to doing that, just don't have a good reason to do
so.  As the OSD work progresses this may become clear to me (PERFORM
SCSI COMMAND and PERFORM TASK MANAGEMENT FUNCTION).

		-- Pete