[Stgt-devel] [PATCH] iscsi param cleanup

[FUJITA Tomonori]

From: Pete Wyckoff <pw at osc.edu>
Subject: [Stgt-devel] [PATCH] iscsi param cleanup
Date: Thu, 26 Jul 2007 19:18:13 -0400

> Remove inconsistencies in param structures and index usage.  This
> seems like the cleanest way to keep the three separate lists of 19
> parameters in sync.  The three spots are:  lookup of special params
> by index #defines during login, session defaults, and target
> defaults.  This fixes one real (although oddball) bug and several
> potential bugs.
> 
> The real bug left the recv dlength size at 8k in spite of both
> initiator and target wanting 256k: text_add_key thought 256k was
> default and did not bother to send it.  The OFMarker code was errant
> too, but it is unlikely that that was ever a problem for someone.
> 
> Target parameter defaults are not changed.  Except for the case
> where you asked for a dlength of 256k using an explicit iscsiadm
> target update command.
> 
> Further cleanups to iscsi_if.h would be possible.  Most of that is
> legacy code from the target-in-kernel days.
>
> Signed-off-by: Pete Wyckoff <pw at osc.edu>
> ---
>  usr/iscsi/iscsi_if.h |   43 +++++++------------------------------------
>  usr/iscsi/iscsid.h   |    4 ----
>  usr/iscsi/param.c    |   43 ++++++++++++++++++++++++++++++++++++-------
>  usr/iscsi/param.h    |    4 ++++
>  usr/iscsi/target.c   |   38 +++++++++++++++++++-------------------
>  5 files changed, 66 insertions(+), 66 deletions(-)

Applied, thanks.

But we might restore some of the parameters that you removed to
support iSCSI HW cards in the future.