[Stgt-devel] [PATCH] Move device type to LUN
Tue Jun 5 15:38:26 CEST 2007
I really think it's more reasonable to have the device type
bound to the LUN, not the target. It feels so SPI-ish to
have it bound to the target. And IMHO it really restricts the
flexibility if a target can only support a single device type.
This patch moves the device type down to the LUN structure.
And in doing so we now also have the proper peripheral device
type and peripheral device qualifier attributes for the INQUIRY
Patches are on top of Mark Harvey's latest patchset.
One thing puzzles me, though: do we support commands with no
LUN attached to it? IE is it valid to have 'cmd->dev == NULL'?
If so: where is the point here? If that's our handling of a
non-existing LUN 0 we should rather add a proper LUN 0 and
treat cmd->dev == NULL as an error case ...
Comments, etc are welcome.
Dr. Hannes Reinecke zSeries & Storage
hare at suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Markus Rex, HRB 16746 (AG N?rnberg)
-------------- next part --------------
More information about the stgt