[Stgt-devel] [Patch 2/6] Remove test condition with only one outcome

Mark Harvey markh794
Wed Jun 20 09:59:45 CEST 2007


>From 4bd3578626e448426de12cb6918f02627f305d11 Mon Sep 17 00:00:00 2001
From: Mark Harvey <markh794 at gmail.com>
Date: Wed, 20 Jun 2007 17:32:42 +1000
Subject: Removed unused test condition

Removed test for SAM_STAT_GOOD as this is the only possible outcome.

Signed-off-by: Mark Harvey <markh794 at gmail.com>
---
 usr/ibmvio/ibmvio.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/usr/ibmvio/ibmvio.c b/usr/ibmvio/ibmvio.c
index 1b1785d..b784f3e 100644
--- a/usr/ibmvio/ibmvio.c
+++ b/usr/ibmvio/ibmvio.c
@@ -138,7 +138,6 @@ static int __ibmvio_inquiry(int host_no, struct scsi_cmd *cmd, uint8_t *data)
 
 static int ibmvio_inquiry(int host_no, struct scsi_cmd *cmd)
 {
-	int ret = SAM_STAT_CHECK_CONDITION;
 	uint8_t *data, *scb = cmd->scb;
 	unsigned char key = ILLEGAL_REQUEST, asc = 0x24;
 
@@ -156,13 +155,9 @@ static int ibmvio_inquiry(int host_no, struct scsi_cmd *cmd)
 		}
 		memset(data, 0, pagesize);
 		cmd->len = __ibmvio_inquiry(host_no, cmd, data);
-		ret = SAM_STAT_GOOD;
 	} else
 		return spc_inquiry(host_no, cmd);
 
-	if (ret != SAM_STAT_GOOD)
-		goto sense;
-
 	cmd->len = min_t(int, cmd->len, scb[4]);
 	cmd->uaddr = (unsigned long) data;
 
-- 
1.5.2.1








More information about the stgt mailing list