[Stgt-devel] [Patch 1/2] Merge lu_phy_attr struct into scsi_lu

Bastian Blank waldi
Fri Jun 15 15:03:05 CEST 2007

On Fri, Jun 15, 2007 at 05:55:11PM +1000, Mark Harvey wrote:
> +	memcpy(lu->attrs.product_id, "OSD", 16);

This code leaks 12 bytes of memory. "OSD" is 4 bytes long and
nullterminated. The whole thing is undefined behaviour.


	"We have the right to survive!"
	"Not by killing others."
		-- Deela and Kirk, "Wink of An Eye", stardate 5710.5

More information about the stgt mailing list