[Stgt-devel] [PATCH 4/4] OSD command parser

[Pete Wyckoff]

fujita.tomonori at lab.ntt.co.jp wrote on Mon, 05 Mar 2007 09:50 +0900:
> It doesn't work at all. Currently, it only shows that we will support
> osd someday. ;)

It works!  Well, I have a local patch to add a backedio_template to
talk to our emulator, and then it works.

Here is the much reduced set of generic patches I use.  You are
probably working on all this already, though (scb length, AHS,
bidirectional).  The only one you may want to apply directly is the
osd one.

Regarding sense format.  OSD must use descriptor format.  The rest
of stgt uses fixed format.  You will see how I have to redefine
things like osd_test_unit just to be able to send the right sense
format.  Perhaps we should have a field in device_type_template that
specifies a function to build the basic sense header?  Let me know
and I will clean it up.

I'd also like to add a "illegal_op" function pointer in the
device_type_template to simplify the long listing at the end of
osd.c and others.  Semantics would be:  ops[cdb[0]] != NULL ? call
the function, else call ->illegal_op().

		-- Pete