[Stgt-devel] [Patch 0/8 ] Core stgt update

Mark Harvey markh794
Wed May 23 04:56:32 CEST 2007

Again - Sorry for the inclusion of attachments. gmail corrupts tab chars...

This patch has grown way beyond what I was initially planning on submitting.
The attachment included with this is a single patch with all the below.

Note: Patchs against:

commit 2ff8cb4bf6682469e2f75c47a7f155b9690cf9a1
Author: FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp>
Date:   Wed May 2 18:41:55 2007 +0900

    update the iSCSI descriptions

    Signed-off-by: FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp>

Patch 1 : Setup .device_init, device_shutdown & device_config to the
device template.
             Move target setup to each 'module' although they all
currently call a common routine in spc.c. The smc module will add to
this when submitted in later patches.
             Also some 'cruft' in spc_illegal_op to log the SCSI
command being rejected. (I can't figure out an easy way of removing
this section of the patch without a lot of fiddling. This will be
cleaned up with one of the following patch (2 x 8) in this patch set.

Patch 2 : Combine INQUIRY into a common spc_inquiry routine.
              Ability to define if a device can handle removable media
              Moved scsi_sn, scsi_id and d_sense (now sense_format)
into a common struct with other INQUIRY related data.
              Moved / split up tgtadm.h into two sections. As the
tgtadm error codes are required by other modules, I've moved the error
code into tgtadm_error.h so I don't have to include the whold tgtadm.h
in with the SCSI target.

Patch 3 : Added the ability to change/tune SCSI Inquiry params:
            Vendor Identification
            Product Identification
            Product Revision
            Sense format
            If media is 'removable'

Patch 4 : Add support for MODE SENSE(6) and MODE SENSE(10) commands.
            This is a major change in that the mode pages are
configured/defined at setup time using the following example for MODE

# Format mode page
tgtadm --lld iscsi --mode logicalunit --op update --tid $TID --lun 0 \
       --params ModePage=3:0:22:0:0:0:0:0:0:0:0:1:0:2:0:0:0:0:0:0:0:0:13:0:0

Patch 5 : Clean up scripts/tgt-core-test script to remove any
un-implemented options.
              Clean up MODE SENSE params to sane values.
              TUR now checks for Power-on/Reset flag.

Patch 6 : Update sense_data_build to use #defined ASC/ASCQ and
standardise on one
common error if data = valloc() fails to 'HARDWARE / INTERNAL_TARGET_FAILURE'

Patch 7 : Force Disable Block Descriptor to be set for MMC mode sense
as per t10 doco.

Patch 8 : Attempt to document the 'configuration' options for each
target. - Work in progress..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: big.diff
Type: text/x-patch
Size: 67832 bytes
Desc: not available
Url : https://lists.berlios.de/pipermail/stgt-devel/attachments/20070523/842888c6/attachment-0001.bin 

More information about the stgt mailing list