[Stgt-devel] [Patch 1/8 ] Setup .device_init, device_shutdown & device_config to the device template.

[FUJITA Tomonori]

From: "Mark Harvey" <markh794 at gmail.com>
Subject: Re: [Stgt-devel] [Patch 1/8 ] Setup .device_init,	device_shutdown & device_config to the device template.
Date: Wed, 30 May 2007 13:07:06 +1000

> This is my first attempt at submitting code to any project, so I
> appreciate your feedback & patience.

No problem. Thanks a lot for the hard work.


> On 5/30/07, FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> wrote:
> > Thanks for the patches. Sorry for the delay.
> >
> > > diff --git a/usr/mmc.c b/usr/mmc.c
> > > index e9cc479..d53d0f3 100644
> > > --- a/usr/mmc.c
> > > +++ b/usr/mmc.c
> > > @@ -121,10 +121,24 @@ static int mmc_read_capacity(int host_no, struct scsi_cmd *cmd)
> > >       return SAM_STAT_GOOD;
> > >  }
> > >
> >
> > trailing spaces
> 
> OK - "trailing spaces" is a subject I'm unsure about.
> 
> Looking at the code, a 'cat -E mmc.c' shows no trailing spaces...

Sorry, this part is ok. There are two trailing spaces in the first
patch.

fujita at arbre:~/git/tgt$ git-apply --whitespace=error ~/1x8.diff
Adds trailing whitespace.
/home/fujita/1x8.diff:115:                              " %02x %02x %02x %02x",
Adds trailing whitespace.
/home/fujita/1x8.diff:122:                              " %02x %02x %02x %02x %02x %02x"
fatal: 2 lines add trailing whitespaces.

Putting (setq-default show-trailing-whitespace t) to .emacs might
help. You can do the same thing with vi though I can't recall how.


> > > +     uint8_t         pcode = cmd->scb[2] & 0x3f;
> > > +     uint64_t        size;
> > > +     uint8_t         *data = NULL;
> > > +     unsigned char   key = ILLEGAL_REQUEST;
> > > +     uint16_t        asc_ascq = E_INVALID_FIELD_IN_CDB;
> > > +     struct  mode    * m;
> >
> > Can you read the Linux coding style document, fix and resubmit the
> > patches? If this is the last patchset that you send (hopefully not),
> > I'll fix them this time.
> 
> Hopefully it is just the beginning.
> 
> My aim is for complete SMC / SSC / SPC + other SCSI-3 support.

Thanks, I'm looking forward to it.