[Stgt-devel] [PATCH 10/20] iser connection transport data

[FUJITA Tomonori]

On Wed, 14 Nov 2007 14:05:03 -0500
Pete Wyckoff <pw at osc.edu> wrote:

> tomof at acm.org wrote on Wed, 14 Nov 2007 23:33 +0900:
> > Moving connection allocation to transport would work better for iSER?
> > 
> > This patch is against the lastest git tree
> > (09532079071d65ec62dae982324ab07a895e16f1).
> [..]
> > -struct tcp_conn_info {
> > +struct iscsi_tcp_connection {
> >  	int fd;
> > +
> > +	struct iscsi_connection iscsi_conn;
> >  };
> 
> Sure, good idea.  It will create a bit of churn against the later
> patches but easily fixed.  Note that iser adds a task->trans_data
> too; you could treat it similarly.

Yeah, I think that moving task allocation to transport would simplify
the code too.


> Also note the ep_conn_init() we need.  It is called _after_ login
> negotiation, not at allocation time, unlike your new conn_init().

OK, iSER seems to allocate something based on the negotiated
parameters.


> May want to change the name so people aren't confused about this.

Yeah, we use init_* for allocation time, so I prefer to have a new
name for a hook called after login negotiation.

BTW, I don't intend to add ep_ to all the hooks in iscsi_transport. I
just copied 'end point' name from open-iscsi. I have to rename some of
them (like ep_init).


> ep_task_init() is okay; it is called at task allocation time.