[Stgt-devel] [PATCH 03/20] iser transport buf

[FUJITA Tomonori]

On Tue, 16 Oct 2007 11:18:57 -0400
Pete Wyckoff <pw at osc.edu> wrote:

> For RDMA, it is often nice to use data from a pool of pre-registered
> buffers.  To do this, the transport allocates memory for a response and
> passes it down to the devices to fill.  Some operations, though,
> allocate their own buffers and return that new memory instead.  These
> are usually small and the allocation is just done for convenience to
> avoid length bounds checking.  Copy the data into the provided transport
> buffer instead.

Do you really need pre-registered buffers for INQUERY, non I/O
commands?

Using pre-registerd buffers might make the code simpler than handling
both pre-registerd and normal buffers, but we already need to handle
something like that for mmapped I/Os.


> Also fixes some leaks of these extra buffers in error paths, and cleans
> up unreachable code in ibmvio inquiry.

Can you send a separate patch to do that?