[PATCH] tgt-admin cleanups

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Fri Aug 15 09:11:55 CEST 2008


On Thu, 14 Aug 2008 14:39:12 +0200
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> Some cleanups to tgt-admin code:
> 
> - don't assume cid is 0 when removing targets (check for a proper cid)
> - helper subroutines for getting target data (account information, users etc).
> - only output "default-driver" if all targets use the same driver in --dump
> - don't output "initiator-address ALL" if the target accepts ALL connections (in --dump) - it's the default value if initiator-address is not specified anyway
> 
> 
> Signed-off-by: Tomasz Chmielewski <mangoo at wpkg.org>
> 
> diff --git a/scripts/tgt-admin b/scripts/tgt-admin
> index 170035b..79c74fc 100755
> --- a/scripts/tgt-admin
> +++ b/scripts/tgt-admin

Hm, the patch is corrupted?

fujita at viola:~/git/tgt$ patch -p1 < ~/Mail/inbox/11
patching file scripts/tgt-admin
patch: **** malformed patch at line 89: }

Can you resend a proper one?

Seems the patch includes white spaces. I would appreciate if you could
fix them too.

Thanks,



More information about the stgt mailing list